Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See extended details at #159, but essentially,
\xHH
for values above7F
doesn't work the same in Oniguruma (the regex engine used for TextMate grammars) as in other flavors of regex. As a result, a standalone unenclosed\xff
like the one corrected here is an invalid UTF-8 encoded byte value, rather than a valid code point value as it would be if using the enclosed version\x{ff}
.This error is currently leading to highlighting bugs with some input strings (code points above
FF
are not matched by this negated range), and preventing the Hack grammar from working at all with Shiki's JS engine.The adjacent
\x7f
that I also changed was already valid, but I changed it for consistency.Note that this was the only place the invalid
\\x7f-\\xff
appeared, but the valid/correct version\\x{7f}-\\x{ff}
already appears 28 times in the same file.